Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new term "Sidecar Container" #3353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fharris
Copy link

@fharris fharris commented Nov 14, 2024

Describe your changes

Created new term "Sidecar Container"

Related issue number or link (ex: resolves #issue-number)

resolves #2958

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@github-actions github-actions bot added the lang/en for English label Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 69bf8d0
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/673c96684e9c030008ade9c7
😎 Deploy Preview https://deploy-preview-3353--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Fernando Harris <[email protected]>
@fharris
Copy link
Author

fharris commented Nov 14, 2024

@iamNoah1 , would you please have a look ? Thanks.

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! LGTM!!

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamNoah1 iamNoah1 self-assigned this Nov 20, 2024
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the content, especially the introduction. Everything you wrote is correct, still, I we have to be a bit picky and more precise.


## Problem it addresses

There are scenarios where it is convenient to group [containers](/container/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are scenarios where it is convenient to group [containers](/container/)
There are scenarios where it is convenient to group [containers](/container/) and their lifecycle

## Problem it addresses

There are scenarios where it is convenient to group [containers](/container/)
to deal with cross-platform requirements or shared functionality.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to deal with cross-platform requirements or shared functionality.
to deal with scenarios


There are scenarios where it is convenient to group [containers](/container/)
to deal with cross-platform requirements or shared functionality.
Such scenarios include [observability](/observability/) topics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Such scenarios include [observability](/observability/) topics

to deal with cross-platform requirements or shared functionality.
Such scenarios include [observability](/observability/) topics
like logging, monitoring, tracing, but also security, and networking.
For example, when multiple microservices have their sidecar containers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we talk already about the solution. This would be where you should show how collecting logs would look without the sidecar container.


## How it helps

The term "sidecar" comes from the representation of a classic motorcycle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The term "sidecar" comes from the representation of a classic motorcycle

This approach consists of using a separated process
running on a secondary container to address problems
that aren't unique to a single application
but rather to the entire platform where the application is running.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
but rather to the entire platform where the application is running.

We already kinda said that the problems are not unique to an application, but rather cross-platform relevant

including storage and networking, as the main container.
While doing this, it frees the main container to be focused on functional tasks
or exposing business capabilities.
As a secondary container, the "sidecar" takes care of platform related tasks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As a secondary container, the "sidecar" takes care of platform related tasks

redundant

While doing this, it frees the main container to be focused on functional tasks
or exposing business capabilities.
As a secondary container, the "sidecar" takes care of platform related tasks
such as logging, monitoring or security.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
such as logging, monitoring or security.

but rather to the entire platform where the application is running.
The Sidecar Container will share the same resources,
including storage and networking, as the main container.
While doing this, it frees the main container to be focused on functional tasks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a bit vague. I would rather be happy to see a more specific example. For instance something like this:

This makes it easy for a logging sidecar to collect logs from the main application without needing to change anything in the main application. The sidecar could read the same directory, the main application writes its logs to.

or exposing business capabilities.
As a secondary container, the "sidecar" takes care of platform related tasks
such as logging, monitoring or security.
It enforces the principle of separation of concerns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you accept my suggested change some comments above this sentence could become redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

[New term] Sidecar container
4 participants