Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TAG leadership election governance template #1195
base: main
Are you sure you want to change the base?
Add TAG leadership election governance template #1195
Changes from all commits
c4ce284
1b9d268
807c058
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick question: What is the purpose of calling this out versus making it part of the list below? It seems to already be somewhat related to the commenting on PRs, etc. issue below.
Is the author of a PR the person who created it? Is any person who did a lot of the work on it an author? What about someone who reviewed and commented heavily on it? Do all PRs regardless of length / purpose / complexity count the same here?
I know this is all subjective and I'm not proposing to define all the corner cases. I'd actually prefer to make this less specific and less emphasized. My concern is that I don't want someone with imposter syndrome who has been a great contributor, but who didn't create a PR to feel like their application shouldn't be put forth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good points @JustinCappos.
If i understand it correctly, the intent here was to define observable metrics to confirm that individuals being nominated are familiar with, have performed, and contributed meaningfully to the TAG. Since the existence and governance of the TAGs are managed and orchestrated through GitHub, its important to confirm such activity has occurred therein.
Given the collaborative nature of many pull requests from our TAGs, it is reasonable to expect that over the course of a potential candidate's involvement in the TAG that they have assisted in triaging, reviewing pull requests, updating/changing/creating new content in the TAG repo, and performed other git observable and trackable activities that demonstrate a deeper level of active involvement in the group's success beyond discussions and slack messages. Effectively demonstrating skills, management, and forethought that we would expect from the leaders of our TAGs.
Would other's confirm my understanding?