Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hadolint tool #27

Closed
wants to merge 26 commits into from
Closed

Conversation

diegorodriguez31
Copy link
Contributor

@diegorodriguez31 diegorodriguez31 commented Sep 13, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Add hadolint tool and a test to see it works well

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@diegorodriguez31 diegorodriguez31 added the enhancement New feature or request label Sep 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2021

Results of the CI pipeline

============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-6.0.2, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/runner/work/sonar-scanner/sonar-scanner/tests
collecting ... collected 19 items

test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_c_cpp PASSED [ 5%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_fortran_77 PASSED [ 10%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_fortran_90 PASSED [ 15%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_java PASSED [ 21%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_python PASSED [ 26%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_language_shell PASSED [ 31%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_cppcheck PASSED [ 36%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_frama_c PASSED [ 42%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_hadolint PASSED [ 47%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_infer PASSED [ 52%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_pylint PASSED [ 57%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_rats PASSED [ 63%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_shellcheck PASSED [ 68%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_tool_vera PASSED [ 73%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_import_cppcheck_results PASSED [ 78%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_import_framac_results PASSED [ 84%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_import_pylint_results PASSED [ 89%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_import_rats_results PASSED [ 94%]
test_cnes_sonar_scanner.py::TestCNESSonarScanner::test_import_vera_results PASSED [100%]

======================== 19 passed in 470.56s (0:07:50) ========================

tests/.cache/v/cache/lastfailed Outdated Show resolved Hide resolved
tests/docker/reference-hadolint-results.xml Outdated Show resolved Hide resolved
@diegorodriguez31 diegorodriguez31 changed the title Feature hadolint in python Add hadolint tool Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker build fail Add hadolint support
3 participants