Skip to content

Commit

Permalink
WIP. Rename the column names and avoid to reassign the variable custo…
Browse files Browse the repository at this point in the history
…mPackages

Signed-off-by: cmoulliard <[email protected]>
  • Loading branch information
cmoulliard committed Dec 24, 2024
1 parent 052a8aa commit cf21fc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/cmd/get/packages.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func printPackages(ctx context.Context, outWriter io.Writer, kubeClient client.C
}
} else {
// Get the custom package using its name
customPackages := v1alpha1.CustomPackageList{}
customPackages = v1alpha1.CustomPackageList{}
for _, name := range packages {
cp, err := getPackageByName(ctx, kubeClient, idpbuilderNamespace, name)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions pkg/printer/package.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ func (pp PackagePrinter) PrintOutput(format string) error {
func generatePackageTable(packagesTable []entity.Package) metav1.Table {
table := &metav1.Table{}
table.ColumnDefinitions = []metav1.TableColumnDefinition{
{Name: "Name", Type: "string"},
{Name: "Namespace", Type: "string"},
{Name: "GitRepository", Type: "string"},
{Name: "Custom package name", Type: "string"},
{Name: "idp namespace", Type: "string"},
{Name: "Git Repository", Type: "string"},
}
for _, p := range packagesTable {
row := metav1.TableRow{
Expand Down

0 comments on commit cf21fc8

Please sign in to comment.