Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use https for gitea #121

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: use https for gitea #121

merged 2 commits into from
Dec 19, 2023

Conversation

nimakaviani
Copy link
Contributor

  • enable skipTLSVerify
  • fix documentation

closes #113

- enable skipTLSVerify
- fix documentation

closes #113

Signed-off-by: Nima Kaviani <[email protected]>
@nimakaviani nimakaviani requested a review from nabuskey December 16, 2023 03:12
@@ -13,7 +15,7 @@ import (
"github.com/cnoe-io/idpbuilder/pkg/util"
"github.com/go-git/go-git/v5"
"github.com/go-git/go-git/v5/plumbing/object"
"github.com/go-git/go-git/v5/plumbing/transport/http"
gohttp "github.com/go-git/go-git/v5/plumbing/transport/http"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why name it gohttp? Should be something like gogithttp if you want to be explicit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Signed-off-by: Nima Kaviani <[email protected]>
@nimakaviani nimakaviani merged commit 9cf1434 into main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use https both internally and externally when using Gitea
2 participants