-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Add codespaces/devpod support #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Left some comments, please take a look
c5a4ea9
to
9d73985
Compare
I had to remove forwardPorts from devcontainers.json as this prevented exposing port 8843 in localhost, it wanted only to expose to .github.dev host name. forwardPorts only worked for devpod.
and any other hostname handle by nginx ingress |
Some things I've noticed about trying to get it working in codespaces:
So if we want to get this to work in Codespaces flawlessly in browser, we need to configure our core packages for this purpose specifically. If GH CLI is used locally, it looks like you can do this without further tweaks. |
This shouldn't be necessary and we probably should not ask users to do this because organization security policies may not allow this kind of modifications. The domain names |
@nabuskey I agree it would be better experience to have idpbuilder work with the external hostname given by Codespaces. I think is matter telling the user to find and replace in the yamls I will test this setup [1] https://docs.github.com/en/codespaces/developing-in-a-codespace/forwarding-ports-in-your-codespace |
Just realized even if we can predict the hostname, we will need different ports or path to route at the ingress with a rewrite to / when sent to backend |
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
14c88f1
to
62424f5
Compare
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
I think this is ready for merging, is a very basic dev environment for go, and if user wants to use idpbuilder is also has docker in docker that user can use idpbuilder |
Signed-off-by: Carlos Santana <[email protected]>
@nabuskey please take a look I addressed your feedback. The files now contain the absolute minimum for an user to use codespaces, devpod, docker, to have a golang environment to make changes to idpbuilder and test |
LGTM! defering to Manabu to squash and merge. |
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support to be able to run idpbuilder on cloud dev environment