Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allocate memory for system in kind #200

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

csantanapr
Copy link
Contributor

Fixes #197

@nabuskey
Copy link
Collaborator

I actually don't know why these were in place. We can certainly reserve memory for system resources but 4G does seem too much. @greghaynes Any consequences for reducing these?

@csantanapr
Copy link
Contributor Author

Can we get an update on this PR?
Some users can benefit of been able to run idpbuilder in systems with lower memory than 12GB of RAM

@csantanapr csantanapr closed this Apr 24, 2024
@greghaynes
Copy link
Contributor

I dont think this was intentional - I'm pretty sure this came in when we copied an example configuration.

@greghaynes
Copy link
Contributor

@csantanapr did you intentionally close this? Removing this memory requirement seems reasonable to me.

@nimakaviani
Copy link
Contributor

re-opening. i think closing this was accidental.

@nimakaviani nimakaviani reopened this Apr 24, 2024
@nabuskey nabuskey merged commit 1f9697b into cnoe-io:main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: system-reserved memory too high
4 participants