Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change setupLog.V(1) to setupLog.info to log some missing messages #397

Closed
wants to merge 1 commit into from
Closed

Change setupLog.V(1) to setupLog.info to log some missing messages #397

wants to merge 1 commit into from

Conversation

cmoulliard
Copy link
Contributor

@cmoulliard cmoulliard commented Oct 4, 2024 •
edited
Loading

@cmoulliard cmoulliard changed the title Change logger.V(1) to logger.info to log some missing messages Change setupLog.V(1) to setupLog.info to log some missing messages Oct 4, 2024
nabuskey
nabuskey reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually made these debug messages because they aren't really relevant for end users. If more verbose log messages are required, you can always increase the verbosity with the -l flag.

@cmoulliard
Copy link
Contributor Author

I actually made these debug messages because they aren't really relevant for end users. If more verbose log messages are required, you can always increase the verbosity with the -l flag.

This is why you are using setupLog.V(1) ? Why don't we then use then (like for java language) a debug mode and that we log such messages using setupLog.debug() ?

@nabuskey
Copy link
Collaborator

nabuskey commented Oct 7, 2024

We can change the naming but v(1) is commonly used. See: https://github.com/kubernetes-sigs/controller-runtime/blob/main/TMP-LOGGING.md

@cmoulliard
Copy link
Contributor Author

Ok. I will close this PR as such a change is not needed

@cmoulliard cmoulliard closed this Oct 9, 2024
@cmoulliard cmoulliard deleted the change-logger branch October 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabuskey nabuskey nabuskey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoulliard @nabuskey