New command to list the custom packages

[cmoulliard]

• New command to list the custom packages
• See: Add list package(s) command #465

[cmoulliard]

Example of what the code produce now

Custom packages added

❯ idp create --color --recreate --name dummy --port 9443 \
   -p https://github.com/cnoe-io/stacks//basic/package1 \
   -p https://github.com/cnoe-io/stacks//basic/package2

What the command idp get packages prints

// A custom package
❯ ./idpbuilder get packages -p app-my-app
CUSTOM PACKAGE NAME   IDP NAMESPACE      GIT REPOSITORY                                                                      STATUS
app-my-app            idpbuilder-dummy   https://gitea.cnoe.localtest.me:9443/giteaAdmin/idpbuilder-dummy-my-app-manifests   true

// All the custom packages
~/code/cnoe/fork-idpbuilder on list-packages •
❯ ./idpbuilder get packages
CUSTOM PACKAGE NAME   IDP NAMESPACE      GIT REPOSITORY                                                                      STATUS
app-guestbook         idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          true
app-my-app            idpbuilder-dummy   https://gitea.cnoe.localtest.me:9443/giteaAdmin/idpbuilder-dummy-my-app-manifests   true
app2-guestbook2       idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          true

~/code/cnoe/fork-idpbuilder on list-packages •

[nabuskey]

Can we add additional printer columns for the package type?

https://book.kubebuilder.io/reference/generating-crd#additional-printer-columns

https://github.com/cnoe-io/idpbuilder/blob/main/api/v1alpha1/custom_package_types.go

[nabuskey]

Can we merge all structs in separate files into one file? Is the entity package for types? If so, we should name the package as types instead of entity.

[cmoulliard]

If so, we should name the package as types instead of entity.

types is a better name. I will rename. Fixed: 6415f7b

[cmoulliard]

Can we merge all structs in separate files into one file?

Why do you want to merge them into one file ? This is easier to figure out what it exists if you have one file/type under the folder name types

[cmoulliard]

Can we add additional printer columns for the package type?

Yes but what do you want to print under this new column ?

[cmoulliard]

Question: Should we also add the column of the Argocd repo as we also have those for git or gitea repo ?
See: 0cd0d7d

❯ ./idpbuilder get packages
CUSTOM PACKAGE NAME   IDP NAMESPACE      GIT REPOSITORY                                                                      ARGOCD REPOSITORY                                                      STATUS
app-guestbook         idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          https://argocd.cnoe.localtest.me:9443/applications/argocd/guestbook    true
app-my-app            idpbuilder-dummy   https://gitea.cnoe.localtest.me:9443/giteaAdmin/idpbuilder-dummy-my-app-manifests   https://argocd.cnoe.localtest.me:9443/applications/argocd/my-app       true
app2-guestbook2       idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          https://argocd.cnoe.localtest.me:9443/applications/argocd/guestbook2   true

[nabuskey]

Let's merge all files under the types directory. I don't think we should have a file for each struct. It's very Java like right now.😅

[nabuskey]

I liked "name" more. Custom package is already implied when you run the command.

[cmoulliard]

Fixed: 9bbd4d5

[nabuskey]

Question: Should we also add the column of the Argocd repo as we also have those for git or gitea repo ?

See: 0cd0d7d

❯ ./idpbuilder get packages

CUSTOM PACKAGE NAME   IDP NAMESPACE      GIT REPOSITORY                                                                      ARGOCD REPOSITORY                                                      STATUS

app-guestbook         idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          https://argocd.cnoe.localtest.me:9443/applications/argocd/guestbook    true

app-my-app            idpbuilder-dummy   https://gitea.cnoe.localtest.me:9443/giteaAdmin/idpbuilder-dummy-my-app-manifests   https://argocd.cnoe.localtest.me:9443/applications/argocd/my-app       true

app2-guestbook2       idpbuilder-dummy   https://github.com/cnoe-io/stacks/tree/main/basic/package2                          https://argocd.cnoe.localtest.me:9443/applications/argocd/guestbook2   true

You mean ArgoCD application URL or git repositories used by ArgoCD applications?

[cmoulliard]

Let's merge all files under the types directory. I don't think we should have a file for each struct. It's very Java like right now.😅

Indeed but that simplify the readability of the code and Java language rocks from this point of view :-)

[cmoulliard]

You mean ArgoCD application URL or git repositories used by ArgoCD applications?

Argocd URL on our IDP to access the application straight from the Argocd UI

[nabuskey]

Let's merge all files under the types directory. I don't think we should have a file for each struct. It's very Java like right now.😅

Indeed but that simplify the readability of the code and Java language rocks from this point of view :-)

Yeah I'd rather keep it uniform within this project. If you look at how we define related types for this project, we do that in a single file like here: https://github.com/cnoe-io/idpbuilder/blob/main/api/v1alpha1/custom_package_types.go

So let's merge them into a single file.

[nabuskey]

You mean ArgoCD application URL or git repositories used by ArgoCD applications?

Argocd URL on our IDP to access the application straight from the Argocd UI

I see, then we should change the name of the column. It's currently named ARGOCD REPOSITORY. It should be ARGOCD URL yea?