Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDE capability to CNOE #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

loujaybee
Copy link

Following a conversation with @nimakaviani adding a CDE as a capability to the CNOE framework.

For reference, a couple of CDE implementations built into Uber, Slack and Shopify platforms:

Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @loujaybee ... LGTM.

we should also modify the capability map (on the front page) to show where the CDE sits. I believe it will be to the left of the map and under Application but I wonder whether it is a cross-cutting concept or whether it is a layer somewhere in the cake. Thoughts?

you are more than welcome to directly edit the map and add it, or you can share your thoughts and we can take care of modifying the map and referencing the CDE.

@loujaybee
Copy link
Author

loujaybee commented Jun 5, 2024

image

I believe it will be to the left of the map and under Application but I wonder whether it is a cross-cutting concept or whether it is a layer somewhere in the cake. Thoughts?

Depends on the type of CDE. Some are more infrastructure-oriented, in terms of provisioning the development environment infrastructure itself (more on the "operations" side here) but some are more application focussed at the container level. I personally see CDEs at the intersection of application and operations.

However, to not completely restructure the diagram let's drop on the left.

@loujaybee
Copy link
Author

loujaybee commented Jun 5, 2024

Added in: 8c7057a

image

Is a bit stretched on ultra-wide screens:
image

And truncated on mobile ones:
image

Haven't yet found an elegant solution without refactoring too much. Could be good enough as is.

Let me know @nimakaviani, I can try and straighten out further if needed.

@jessesanford
Copy link
Contributor

@loujaybee @nimakaviani don't think we should try to push CDE into either of the existing buckets but maybe instead we can create a new bucket called "Ideation" or "developer tooling" or something that implies pre-commit tooling. This capability sits left of CI in the sdlc of software so it's unique when compared to our existing capabilities in that way.

@greghaynes
Copy link
Contributor

I love this, and fully agree we should add this capability. We are also well positioned to provide a lot of value for implementations of this capability, so its partly self-serving as well.

I don't have a great idea on where to put this in our capability map, but it does seem fairly broad. I'd support this being outside of the existing areas as jesse mentioned.

@nimakaviani
Copy link
Contributor

to move things forward, maybe we keep the text and remove the graph modifications for now and while we are deciding where to put it. sorry @loujaybee, I know it was my ask to add it to the chart, but mind reverting that change?

@loujaybee
Copy link
Author

loujaybee commented Jun 14, 2024

to move things forward, maybe we keep the text and remove the graph modifications for now and while we are deciding where to put it. sorry @loujaybee, I know it was my ask to add it to the chart, but mind reverting that change?

All good ! Reverted the last commit 🙏

Agree generally on direction to figure out where to fit into the graph. More than happy to join a future working group call to talk a bit more about this type of capability.

Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani
Copy link
Contributor

can you please sign the DCO too, and we can get it merged. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants