Refactor: Detail page 레이아웃 수정 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimbobby
requested review from
nakyoung98,
JIS0098,
hankim0904 and
Yoon-kyungLee
올바른 PR 형식올바른 PR 형식입니다. |
JIS0098
approved these changes
Mar 20, 2024
Yoon-kyungLee
approved these changes
Mar 20, 2024
hankim0904
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌요구사항
📌작업 진행 상황 (에러, 막혔던 부분, 그외 궁금한것 등등)
카드컴포넌트 높이측정을 한 이유
우선 카드 컴포넌트의 높이가 데이터에 따라 유동적입니다. 스크롤 했을때 sticky되는 카드 컴포넌트 및 버튼 사이의 간격을 유지해야하기에 버튼의 top위치도 카드컴포넌트의 높이반영하여 계산해서 그 간격을 유지할 수 있도록 해야했어요.. 페이지 내부에 관련 코드가 있으면 나중에 추가 기능을 넣었을 때 코드가 길어질거 같아서 훅으로 따로 빼놓았습니다.
ScrollToTop 버튼 기능 구현은 간단하게 하긴 했는데 여러번 클릭하면 좀 왔다리갔다리 합니다.. 더 좋은 코드 있으시면 ... 수정 ..하면 좋겠습니다..
📌스크린샷 / 테스트결과 (선택)
2024-03-19.11.17.12.mov
📌이슈 번호