Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIS0098
requested review from
nakyoung98,
hankim0904,
kimbobby and
Yoon-kyungLee
올바른 PR 형식올바른 PR 형식입니다. |
kimbobby
approved these changes
Mar 23, 2024
Yoon-kyungLee
approved these changes
Mar 23, 2024
hankim0904
approved these changes
Mar 23, 2024
kimbobby
reviewed
Mar 23, 2024
| @@ -2,7 +2,7 @@ export interface RecruitmentRequest { | |||
| type: string; | |||
| recruitEndAt: string; | |||
| progressPeriod: string; | |||
| capacity: number; | |||
| capacity: number | undefined | null; | |||
kimbobby
approved these changes
Mar 23, 2024
| @@ -17,20 +17,21 @@ export const DROPDOWN_INFO = { | |||
| recruitment: { | |||
| progressPeriod: { | |||
| defaultValue: "진행 기간", | |||
| options: ["1주", "2주", "3주", "1개월", "2개월", "3개월", "4개월", "5개월", "6개월", "6개월 이상"], | |||
| options: ["선택 미정", "1주", "2주", "3주", "1개월", "2개월", "3개월", "4개월", "5개월", "6개월", "6개월 이상"], | |||
There was a problem hiding this comment.
진행기간 "선택 미정" => 협의 후 결정
모집인원 "선택 미정" => 인원 미정
연락 방법 "선택 미정" => 기타
로 변경 해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌요구사항
📌작업 진행 상황 (에러, 막혔던 부분, 그외 궁금한것 등등)
일단 기능구현 먼저하느라 코드를 한파일에 다 적어놨는데 내일 노트북으로 작업을 할 예정이라
일단 피알 먼저 올리고 주말에 리팩토링이랑 수정할 부분 이어하겠습니다
하은님이 작성해주신 유효성 검사 상수를 적용 시키려했는데 타입 오류가 나서
일단 정규식 하드 코딩했습니다 내일 위워크 오시면 여쭤보고 수정하겠습니다
링크 인풋에 이메일은 검사가 잘되는데 url관련 검사 부분에서 유효성 검사가 제대로 안되고있어
리팩토링 하면서 같이 수정해야할 것 같습니다
📌스크린샷 / 테스트결과 (선택)
📌이슈 번호
close #135