Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Card, Stacks, Position 컴포넌트 수정 #41

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

hankim0904
Copy link
Collaborator

@hankim0904 hankim0904 commented Mar 11, 2024

📌요구사항

  • Card, Stacks, Position 컴포넌트 수정

📌작업 진행 상황 (에러, 막혔던 부분, 그외 궁금한것 등등)

  • Card 컴포넌트 클릭 시 onClick 이벤트 대신 Link 태그로 페이지를 이동하게 함
  • Card 컴포넌트 css 속성 추가 (스터디/프로젝트 라벨 부분)
  • Stacks, Position 컴포넌트의 map 메소드의 key 값을 id 대신 name으로 변경
  • Stacks, Position 컴포넌트의 경로를 common 하위로 변경
  • 라벨(ProjectChip) 왼쪽 부분의 border-radius가 적용되지 않는 느낌임
border-radius.mp4

📌스크린샷 / 테스트결과 (선택)

  • 라벨 왼쪽으로 0.2 rem 튀어나오게 바꿈
  • 기술 스택과 포지션이 없는 경우 다음과 같이 나옴

image

  • Stacks, Positions 컴포넌트 변경 후에도 잘 렌더링 됨

image

  • 카드 클릭 시 페이지 이동
Card_path.mp4

📌이슈 번호

Copy link

올바른 PR 형식

올바른 PR 형식입니다.
코드 작성하시느라 수고 많으셨습니다 :)

Copy link
Contributor

@Yoon-kyungLee Yoon-kyungLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용😻

import Stacks from "../../commons/Card/Stacks";
import Positions from "@/components/commons/Card/Positions";
import Stacks from "@/components/commons/Stacks";
import Positions from "@/components/commons/Positions";

// 임시 (id가 꼭 있어야 하는지, index로 key 값을 넘겨주는 방법도 고려)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음에 작업하실 때 이 주석은 삭제해도 좋을 것 같습니다~!

Copy link
Contributor

@kimbobby kimbobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따봉 👍

@hankim0904 hankim0904 merged commit 9670a25 into develop Mar 12, 2024
@kimbobby kimbobby deleted the Refactor/Card branch March 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants