Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smtp starttls compatibility issue #292

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

Ogannesson
Copy link
Contributor

原先mail.v2实现的StartTLS存在问题,导致其与一部分SMTP服务商无法成功握手,此提交将smtp.go的实现转换为gomail.v2以解决StartTLS相关问题,我已分别测试过一家使用StartTLS的服务商(ahasend)和一家使用SSL的服务商(阿里云)。

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatnio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 6:32am

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatnio 🔄 Building (Inspect) Visit Preview Nov 26, 2024 4:55am

@Brave963
Copy link

Brave963 commented Nov 26, 2024

Issue about not supporting StartTLS with Ahasend
此issue已在此pull request得到解决

Copy link
Member

@zmh-program zmh-program left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@zmh-program
Copy link
Member

zmh-program commented Nov 27, 2024

本来之前商业版已经修过这个问题,开源版没有下放。计划将重新投入开源建设 (#285),这段commit还没来的及cherry pick过来,感谢你提前fix 👍 !
image

@zmh-program zmh-program changed the title 将smtp.go转换为gomail.v2实现以解决StartTLS相关问题 fix: smtp starttls compatibility issue Nov 27, 2024
@zmh-program zmh-program merged commit 928319a into coaidev:main Nov 27, 2024
1 check was pending
@Brave963

This comment has been minimized.

@Issues-translate-bot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants