-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update README.md #107
base: master
Are you sure you want to change the base?
update README.md #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Marco2018
The change looks fines, but I'd suggest you do the following things:
- Go through the commit guidelines.
- Go through the newcomer's guide.
- After reading them, squash your commits.
- Modify your commit message as per the other examples given in the guidelines.
- Refer the issue in the PR description (its hard to follow the trail otherwise).
- Be sure to not make the changes from your master branch later on (it can lead to some complications). You don't need to change this for this PR though.
- Make all the changes in the current PR and don't create another one.
After all this is done, someone would merge your PR 🙂
Hi @shashank-b |
Hi @shashank-b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marco2018 Check coala git basics to know how can squashing of commits be done!
Hey! @KVGarg Thank you for your help. I have tried to squash my commits into one. So I reset back the branch and commit once again. It seems commits are squashed into one commit. Is it acceptable for this PR? So sorry I made this PR a little bit complicated. THX! |
avoid-->avoiding Closes coala#99
Yeah @Marco2018 |
@KVGarg Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me likey! 👍🏻
Although you need a rebase or @abhishalya can do that & merge?
Won't be able to rebase as the PR was created from master. @Marco2018 please rebase if you can. |
README.md: Fix docstring typo
avoid -->avoiding
Closes #99