setup.cfg: Enforce 100% branch coverage #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two test classes are renamed to match the coala naming convention. However as the repository does not have 100% coverage fail_under = 100 is omitted manually
A TypeError was being raised if a class attribute with a default had been set to a falsish value. While possible, it is very improbable, and other errors will result.
Creates a list of coverage exceptions in .nocover.yaml which are used in setup.cfg by coverage to ignore them while ensuring any other parts of the code are fully tested. Also rename one function so its signature is on one line as required for coverage to ignore the entire function. Closes coala#282
jayvdb
requested review from
saksham189,
satwikkansal,
virresh,
RaiVaibhav and
ishanSrt
Travis tests have failedHey @jayvdb, |
RaiVaibhav
reviewed
Aug 4, 2018
| jobs: | ||
| include: | ||
| - *check_moban | ||
|
|
There was a problem hiding this comment.
allow_failures:
- *check_moban
?
There was a problem hiding this comment.
No ;-)
That is only done on coala & coala-bears as we have lots of eyes on those two repos, and those two repos see enhancements first (like pytest-reqs is only working on coala core repo atm)
These other repos will not be maintained unless moban forces them to sync.
virresh
approved these changes
Aug 4, 2018
saksham189
approved these changes
Aug 4, 2018
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
yzgyyang
pushed a commit
to yzgyyang/coala-mobans
that referenced
this pull request
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282