Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

green_mode: Choose job count based on environment #296

Merged
merged 1 commit into from
Aug 17, 2018
Merged

green_mode: Choose job count based on environment #296

merged 1 commit into from
Aug 17, 2018

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 15, 2018

Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to #295

@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@jayvdb jayvdb force-pushed the mp-reserve branch 2 times, most recently from 8d82a81 to 01cda10 Compare August 15, 2018 12:30
@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 15, 2018

Depends on https://gitlab.com/coala/mobans/merge_requests/86 to pass the moban job

gitmate-bot
gitmate-bot reviewed Aug 15, 2018
View reviewed changes
tests/green_mode/green_modeTest.py Outdated
@@ -1,5 +1,6 @@
import operator
import os
import sys
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains unused source code.

Origin: PyUnusedCodeBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp98vu00b2/tests/green_mode/green_modeTest.py
+++ b/tmp/tmp98vu00b2/tests/green_mode/green_modeTest.py
@@ -1,6 +1,5 @@
 import operator
 import os
-import sys
 import unittest
 import yaml
 from copy import deepcopy

@TravisBuddy
Copy link

Travis tests have failed

Hey @jayvdb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

coala --non-interactive 
Executing section all...
Executing section all.python...
**** PyUnusedCodeBear [Section <empty> | Severity NORMAL] ****
!    ! This file contains unused source code.
[----] /home/travis/build/coala/coala-quickstart/tests/green_mode/green_modeTest.py
[++++] /home/travis/build/coala/coala-quickstart/tests/green_mode/green_modeTest.py
[   3] import sys
[INFO][12:54:02] Applied 'ShowPatchAction' on 'tests/green_mode/green_modeTest.py' from 'PyUnusedCodeBear'.
Executing section all.quotes...
[WARNING][12:54:02] No files matching '/home/travis/build/coala/coala-quickstart/tests/**.py' were found. If this rule is not required, you can remove it from section [all.quotes] in your .coafile to deactivate this warning.
Executing section all.autopep8...
Executing section all.linelength...
Executing section all.commit...
Executing section all.yml...
[WARNING][12:54:15] No files matching '/home/travis/build/coala/coala-quickstart/tests/**/*.yml' were found. If this rule is not required, you can remove it from section [all.yml] in your .coafile to deactivate this warning.
Executing section cli...

@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@TravisBuddy
Copy link

Travis tests have failed

Hey @jayvdb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

@jayvdb
green_mode: Choose job count based on environment
4e80186 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

2 similar comments
@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@jayvdb jayvdb mentioned this pull request Aug 17, 2018
Open
@TravisBuddy
Copy link

Hey @jayvdb,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@satwikkansal
Copy link
Member

Feels great to see everything green after a long time :p

@jayvdb
Copy link
Member Author

jayvdb commented Aug 17, 2018

ack 4e80186

@jayvdb
Copy link
Member Author

jayvdb commented Aug 17, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit 4e80186 into coala:master Aug 17, 2018
@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitmate-bot gitmate-bot gitmate-bot left review comments

@satwikkansal satwikkansal satwikkansal approved these changes

Assignees
No one assigned
Labels
process/approved size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayvdb @TravisBuddy @satwikkansal @gitmate-bot