openhub/: Use openhub_django pypi package #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KVGarg
force-pushed
the
openhub_django_integration
branch
from
fc7dd93
to
58fab82
Compare
Travis tests have failedHey @KVGarg, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: 39e22f80-b570-11e9-a172-292526d14dc1 |
KVGarg
force-pushed
the
openhub_django_integration
branch
4 times, most recently
from
422e456
to
135e833
Compare
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: 896b45b0-b5ce-11e9-a786-5b97e93928e7 |
KVGarg
force-pushed
the
openhub_django_integration
branch
from
135e833
to
a2acb20
Compare
The updation in model adds new data fields which will be useful, in further work. Also, it will reduce the API calls, which are being made to fetch these information. Instead of making new API Calls, we can get them from webservices and use them directly.
The openhub module got disabled due to some reasons in community project last year. And, currently the module is raising the CI errors which need to be avoided. They can be worked on once we're ready to enable the openhub module once again in this project in future.
As in future, the data will be fetched from coala-webservices intead of @sks444 repository (webservices.coala.io). So, to remove that dependency the tests have been modified accordingly.
Running command ".ci/build.sh" locally on pc used to failed the build, if there is more than one git remote's. Fixes coala#235
KVGarg
force-pushed
the
openhub_django_integration
branch
from
a2acb20
to
86db04a
Compare
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: 5340c1c0-b76a-11e9-8ff7-d1d19cf84925 |
KVGarg
force-pushed
the
openhub_django_integration
branch
from
86db04a
to
9bb2dab
Compare
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: a6ae2660-b76d-11e9-8ff7-d1d19cf84925 |
The enhancement includes addition of materialize css, JQuery, responsiveness, and easy-navigation of website features. The easy-navigatibility is achieved by adding a navbar with display of meta -review and gamification leaderboard on homepage. Apart from this, the activity graph url is omitted from website by displaying the graph itslef on the homepage on large devices. Closes coala#255
The newly created webpage combines the previous two webpages- info.txt and log/index.html. This web-page combines the results of both the pages and shows them in a better UI/UX with additional features of filtering and searching within the existing logs. The logs are fetched from a JSON file which is created from the logs stored in the log file _site/community.log Closes coala#256
The redesigned web-page displays the data in a better UI/UX form with some additional information to make it more interactive and attractive. Closes coala#257
The redesigned web-page provides a nice UI/UX design to the web-page with "search" feature. Closes coala#259
The redesigned webpages provides a enhanced UI/UX design to web-page with additional functionality of searching the contributors. Closes coala#260
The contributor can sign-in with either GitHub or GitLab account provided the user is member of the organization. The validation is being performed via a http request which accepts the access_token retrieved from the netlify o-authentication. Closes coala#262
The netlify form will ask some particular inputs that will be used for validating the user - whether the user is eligible to be a organization member. The checks for it have been defined in coala webservices API which will be accepting form-submissions over a cron-job defined. After the user submits the form, a success message will be displayed. Closes coala#89, coala#266
Show the contributor statistics in the form of charts. The charts will be shown for issues, commits, reviews and for merge requests. And, an overall chart, which will display stats repository wise. Apart from all these charts, the type of issues the contrib has worked on will be shown, with the count of issues the user is working on and the last updated datetime the user data was updated. All this will be shown, only if there is some statistics, otherwise the popup option willn't be shown. Closes coala#268
Not everyone, will be able to fill forms. Only the logged in users will be able to fill them and some of the forms, can only be filled by developers or contributors who are a part of more than one team. At every step, the check is performed whether the user is authenticated or not, to avoid false form submissions. Closes coala#265
Not everyone, will be able to fill forms. Only the logged in users will be able to fill them and some of the forms, can only be filled by developers or contributors who are a part of more than one team. At every step, the check is performed whether the user is authenticated or not, to avoid false form submissions. Closes coala#270
|
Rebase this on top of #261 and Why the CIs are failing? |
The contributors who've participated in GSoC in any year, with the organization can fill up this form. All the valid submissions, will be displayed on the projects website under a new tab, named 'Google Summer of Code` students. Closes coala#273
|
Yeah! I will fix that soon. |
KVGarg
force-pushed
the
openhub_django_integration
branch
from
9bb2dab
to
34313d3
Compare
|
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 5205d0e0-b853-11e9-af6e-3b363318fc0d |
Overriding the default openhub_django URLs so as to define new ones and pass the header and footer context of webpages and make openhub_django templates look similar to that of commuity website. Closes coala#285
KVGarg
force-pushed
the
openhub_django_integration
branch
from
34313d3
to
8daed65
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 98881a00-b858-11e9-af6e-3b363318fc0d |
|
Add a card for this type of page https://deploy-preview-286--coala-community.netlify.com/openhub/outside_committer/4/ |
|
Will make that change in the
|
|
Is this OK? (PR: sks444/openhub-django#6) I could have shown user-image, but we're not getting the username and also, we are fetching it from openhub, so if we want to display image will it be OK to use github image? |
|
I feel like title |
I will add the heading title inside the card and will share that too soon. |
|
Also for all the other pages 1, try putting the title on the card/table and then the search option below it, and then the list of items, and all should be centre-align. |
Center aligning list items! The current version of list items isn't much better than the new ones? Just a thought
|
|
I think the later one looks good, let's take a third person opinion(cc @li-boxuan) and go with that. Also the background color should be the old one right? |
Yes! These screenshots are the changes from openhub-django repo |
|
I think it would look a bit weird if we center align everything |
|
I personally prefer v2, coz a yellow background is not very common |
It will have a light-green bg like we have in v1, the screenshot is taken w/o any bg-color |
Then I think v1 is better. v2 is more common on a narrow screen or mobile phone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding the default openhub_django URLs
so as to define new ones and pass the
header and footer context of webpages and
make openhub_django templates look similar
to that of commuity website.
Closes #285