reports: Add Kriti Rohilla'a GSoC report #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @kriti21, Ruby: 2.3.3docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
refeed
suggested changes
Aug 11, 2018
reports/kriti21.md
Outdated
| - Phase 3 : https://gitlab.com/coala/GSoC/GSoC-2018/milestones/42 | ||
| bio: > | ||
| I am in my pre-final year at University Institute of Engineering and Technology, | ||
| Panjab University. As part of my GSoC 2018 project, I worked on vcs related bears |
There was a problem hiding this comment.
Capitalize VCS as it's an abbreviation
There was a problem hiding this comment.
reports/kriti21.md
Outdated
| - repo: coala-bears | ||
| - link: https://github.com/coala/coala-bears/pull/2576/commits/b51144b2bcc90bbf8a147c6a9e85cc009869bccb | ||
| - details: > | ||
| generate_package.py: Replace touch funtion with library function Path. |
reports/kriti21.md
Outdated
| --- | ||
|
|
||
| ### Git Commit Content Inspection | ||
| coala has a `GitCommitBear` that is responsible for verifying that commits |
reports/kriti21.md
Outdated
|
|
||
| <br> | ||
|
|
||
| 1.) A metadata bear called `VCSCommitMetadataBear` has been implemented which |
There was a problem hiding this comment.
I think markdown syntax for ordered-list is enough (1. .... (without the ))
reports/kriti21.md
Outdated
|
|
||
| <br> | ||
|
|
||
| 2.) GitHub PR merge commits were responsible for travis build failure. Settings |
jayvdb
requested changes
Aug 11, 2018
reports/kriti21.md
Outdated
| - Phase 3 : https://gitlab.com/coala/GSoC/GSoC-2018/milestones/42 | ||
| bio: > | ||
| I am in my pre-final year at University Institute of Engineering and Technology, | ||
| Panjab University. As part of my GSoC 2018 project, I worked on vcs related bears |
There was a problem hiding this comment.
Travis tests have failedHey @kriti21, |
|
Please finish your PRs |
Travis tests have failedHey @kriti21, |
Travis tests have failedHey @kriti21, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
jayvdb
requested changes
Aug 13, 2018
_reports/kriti21.md
Outdated
| GitCommitBear.py: Add settings to ignore GitHub PR merge commits. | ||
| - 5: | ||
| - repo: projects | ||
| - link: https://github.com/coala/projects/pull/600 |
_reports/kriti21.md
Outdated
| organisation_link: https://coala.io | ||
| project: Git Commit Content Inspection | ||
| project_link: https://summerofcode.withgoogle.com/projects/#5636421247827968 | ||
| tarball: https://raw.githubusercontent.com/kriti21/GSoC-2018-Report/master/ProjectPatches.tar |
refeed
reviewed
Aug 13, 2018
_reports/kriti21.md
Outdated
| that cannot disable CI build can be controlled by specifying filename patterns | ||
| in `.coafile`. | ||
|
|
||
| 5. `git revert` commit must be exactly revert of the commit it reverts. For this |
There was a problem hiding this comment.
.. must be exactly the revert ...
kriti21
force-pushed
the
gsocreport
branch
3 times, most recently
from
bc21ccb
to
719598c
Compare
jayvdb
requested changes
Aug 13, 2018
_reports/kriti21.md
Outdated
| commit-content-checks.md: Add issue link to project description. | ||
| - 2: | ||
| - repo: cEPs | ||
| - link: https://github.com/coala/cEPs/pull/114/commits/ea25f09ae08b4bc7423453460b14cb16eb3a0db6 |
There was a problem hiding this comment.
this isnt in your tarball. it should be
and the igitt project .md is missing from this list. it should be included here, as it is hard work, and was related to your current project. It is also "community work" which is good to include
jayvdb
approved these changes
Aug 13, 2018
|
ack 5940739 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-612--coala-projects.netlify.com/gsoc/2018/statusreport/kriti21