report: Add macbox7 GSoC report #614

ankitxjoshi · 2018-08-09T15:10:38Z

https://deploy-preview-614--coala-projects.netlify.com/gsoc/2018/statusreport/macbox7

jayvdb · 2018-08-09T15:16:25Z

https://deploy-preview-614--coala-projects.netlify.com/GSoC/2018/StatusReport/macbox7 is 404

jayvdb · 2018-08-09T15:24:08Z

reports/macbox7.md

+blog: https://macbox7.github.io/Blog-GSOC18/
+
+activity:
+- 0:


these need to be indented.

we dont have a bear for this ;-(

jayvdb · 2018-08-09T15:36:13Z

reports/macbox7.md

+   in a python file. Special handling is also done to detect violations
+   in doctests which other similar plugins fail to perform.
+8. Create a `BuiltinsBear` that is capable of detecting redefinition
+   of python builtins in a file.


file -> module

jayvdb · 2018-08-09T15:37:50Z

reports/macbox7.md

+
+#### Future prospects of the projects
+
+With `PyFlakesASTBear` ready bear developers can use it to detect codesmells


"ready" isnt clear. Is it ready now? If so, using "with .. ready" is redundant, at best.

Also migrating flake8 plugins to this new infrastructure should be easy tasks that people can now work on.

And more importantly, we had planned for this bear framework to be able to load & run flake8 ast plugins as-is, so porting wasnt necessary; that can be mentioned as a medium to large sized project which is now feasible.

virresh · 2018-08-09T17:54:52Z

reports/macbox7.md

+  - 1:
+    - repo: coala-pyflakes
+    - link: https://gitlab.com/coala/bears/coala-pyflakes/commit/9484d8af901153c490812d86809760b14c46d9af
+    - details: PyFlakesASTBear.py: Add PyFlakesASTBear


Use quotes or : will be treated as defining yaml variable

virresh · 2018-08-09T17:55:23Z

reports/macbox7.md

+  - 0:
+    - repo: coala-pyflakes
+    - link: https://gitlab.com/coala/bears/coala-pyflakes/commit/684f1a958dd66fa781e7f03777ffa96b7e6a2ca7
+    - details: nitial commit


Probably a typo

virresh

Add a report_year variable
Pretty sure you aren't a 2017 student :p

TravisBuddy · 2018-08-10T08:23:18Z

Travis tests have failed

Hey @MacBox7,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

jayvdb · 2018-08-11T06:05:18Z

reports/macbox7.md

+email: [email protected]
+blog: https://macbox7.github.io/Blog-GSOC18/
+activity:
+ - 0:


See changes requested at #615

jayvdb · 2018-08-11T06:20:52Z

reports/macbox7.md

+       checker.py: Handle UnboundLocal error for builtins
+ - 52:
+   - repo: pyflakes
+   - link: https://github.com/PyCQA/pyflakes/pull/329


we can get this merged.

jayvdb · 2018-08-11T06:29:32Z

More commits at https://github.com/coala/coala/commits?author=MacBox7 and https://github.com/coala/coala-bears/commits?author=MacBox7

jayvdb · 2018-08-11T06:41:54Z

Also https://gitlab.com/coala/PyPrint/graphs/master and https://gitlab.com/coala/mobans/graphs/master and https://gitlab.com/coala/coala-utils/graphs/master , and maybe others on gitlab ;)

jayvdb · 2018-08-11T11:20:10Z

reports/macbox7.md

+report_year: 2018
+project: Integrate pyflakes-enhanced AST into coala
+project_link: https://summerofcode.withgoogle.com/projects/#5549789140221952
+tarball: https://rawgit.com/MacBox7/GSoC-Report/master/project.tar.gz


need to add another pyflakes patch into this

jayvdb · 2018-08-13T00:11:13Z

reports/macbox7.md

@@ -0,0 +1,489 @@
+---
+layout: report
+permalink: /GSoC/2018/StatusReport/macbox7


remove this and layout:

add date, categories, etc, as shown at https://github.com/coala/projects/pull/633/files#diff-f1164fdbd5814b6d270a59c0f9e3939e

jayvdb · 2018-08-13T11:55:40Z

reports/macbox7.md

+ [Adhika Setya Pramudita](https://github.com/adhikasp),
+ [Steven Myint](https://github.com/myint)
+phase:
+ - Bonding: https://gitlab.com/coala/GSoC/GSoC-2018/milestones/8


jayvdb · 2018-08-13T11:56:02Z

Also needs a rebase

jayvdb · 2018-08-13T12:10:26Z

Still not rebased, and still not fixed #614 (comment)

jayvdb · 2018-08-13T12:19:38Z

_reports/macbox7.md

+ [Adhika Setya Pramudita](https://github.com/adhikasp),
+ [Steven Myint](https://github.com/myint)
+phase:
+ - Bonding: https://gitlab.com/coala/GSoC/GSoC-2018/milestones/8


No error on this line. The only error I am getting is =>

[ 473] The·challenge·of·the·project·was·to·implement·the·`PyFlakesASTBear`·in **** YAMLLintBear [Section: cli | Severity: MAJOR] **** ! ! syntax error: expected '<document start>', but found '<scalar>' [ ] *0. Do (N)othing [ ] 1. (O)pen file [ ] 2. Add (I)gnore comment [ ] Enter number (Ctrl-D to exit):

jayvdb · 2018-08-13T15:59:12Z

@gitmate-bot rebase

gitmate-bot · 2018-08-13T15:59:15Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-08-13T16:00:23Z

Automated rebase with GitMate.io was successful! 🎉

jayvdb · 2018-08-13T16:12:52Z

@gitmate-bot ff

gitmate-bot · 2018-08-13T16:12:54Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-08-13T16:13:50Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/M labels Aug 9, 2018

jayvdb requested changes Aug 9, 2018

View reviewed changes

jayvdb reviewed Aug 9, 2018

View reviewed changes

jayvdb requested changes Aug 9, 2018

View reviewed changes

ankitxjoshi force-pushed the report-pyflakes branch from 261f4f1 to 1073c00 Compare August 9, 2018 17:43

virresh reviewed Aug 9, 2018

View reviewed changes

ankitxjoshi force-pushed the report-pyflakes branch 2 times, most recently from 722f998 to 5e853c0 Compare August 9, 2018 18:16

virresh suggested changes Aug 9, 2018

View reviewed changes

ankitxjoshi force-pushed the report-pyflakes branch from 5e853c0 to d41fffc Compare August 10, 2018 08:11

ankitxjoshi changed the title ~~reports: Add coala-pyflakes report~~ report: Add virresh's GSoC report Aug 10, 2018

ankitxjoshi changed the title ~~report: Add virresh's GSoC report~~ report: Add macbox7 GSoC report Aug 10, 2018

ankitxjoshi force-pushed the report-pyflakes branch from d41fffc to b385241 Compare August 10, 2018 08:42

jayvdb requested changes Aug 11, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 11, 2018

jayvdb reviewed Aug 11, 2018

View reviewed changes

ankitxjoshi force-pushed the report-pyflakes branch from b385241 to 1e7e89d Compare August 12, 2018 22:07

gitmate-bot added process/pending review and removed process/wip labels Aug 12, 2018

jayvdb requested changes Aug 13, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 13, 2018

ankitxjoshi force-pushed the report-pyflakes branch from 1e7e89d to 6067e0a Compare August 13, 2018 00:28

gitmate-bot added process/pending review and removed process/wip labels Aug 13, 2018

jayvdb requested changes Aug 13, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 13, 2018

ankitxjoshi force-pushed the report-pyflakes branch from a66d9f8 to 5c85a2a Compare August 13, 2018 12:02

gitmate-bot added process/pending review and removed process/wip labels Aug 13, 2018

jayvdb added process/wip and removed process/pending review labels Aug 13, 2018

ankitxjoshi force-pushed the report-pyflakes branch from 5c85a2a to 3215087 Compare August 13, 2018 12:14

gitmate-bot added process/pending review and removed process/wip labels Aug 13, 2018

jayvdb requested changes Aug 13, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 13, 2018

report: Add macbox7 GSoC report

e8b940b

gitmate-bot force-pushed the report-pyflakes branch from 3215087 to e8b940b Compare August 13, 2018 16:00

gitmate-bot added process/pending review and removed process/wip labels Aug 13, 2018

gitmate-bot merged commit e8b940b into coala:master Aug 13, 2018

gitmate-bot deployed to github-pages August 13, 2018 16:13 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

report: Add macbox7 GSoC report #614

report: Add macbox7 GSoC report #614

ankitxjoshi commented Aug 9, 2018 •

edited by jayvdb

Loading

jayvdb commented Aug 9, 2018

jayvdb Aug 9, 2018

jayvdb Aug 9, 2018

jayvdb Aug 9, 2018

virresh Aug 9, 2018

virresh Aug 9, 2018 •

edited

Loading

virresh left a comment

TravisBuddy commented Aug 10, 2018

jayvdb Aug 11, 2018

jayvdb Aug 11, 2018

jayvdb Aug 11, 2018

jayvdb commented Aug 11, 2018

jayvdb commented Aug 11, 2018

jayvdb Aug 11, 2018

jayvdb Aug 13, 2018

jayvdb Aug 13, 2018

jayvdb commented Aug 13, 2018

jayvdb commented Aug 13, 2018

jayvdb Aug 13, 2018

ankitxjoshi Aug 13, 2018

jayvdb commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

jayvdb commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018


		#### Future prospects of the projects

		With `PyFlakesASTBear` ready bear developers can use it to detect codesmells

report: Add macbox7 GSoC report #614

report: Add macbox7 GSoC report #614

Conversation

ankitxjoshi commented Aug 9, 2018 • edited by jayvdb Loading

jayvdb commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

virresh Aug 9, 2018 • edited Loading

Choose a reason for hiding this comment

virresh left a comment

Choose a reason for hiding this comment

TravisBuddy commented Aug 10, 2018

Travis tests have failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Aug 11, 2018

jayvdb commented Aug 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Aug 13, 2018

jayvdb commented Aug 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

jayvdb commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

gitmate-bot commented Aug 13, 2018

ankitxjoshi commented Aug 9, 2018 •

edited by jayvdb

Loading

virresh Aug 9, 2018 •

edited

Loading