reports/example.md: Update GSoC report template #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vamshi99
reviewed
Aug 12, 2018
reports/example.md
Outdated
| - GitHub: | ||
| - username: <github username> | ||
| - link: https://github.com/<github username> | ||
| - gitlab: |
There was a problem hiding this comment.
gitlab --> GitLab, gitter --> Gitter, hackerrank --> HackerRank, openhub --> OpenHub
jayvdb
requested changes
Aug 12, 2018
reports/example.md
Outdated
| tarball: <tarball of patches' link> | ||
| tarball_hash: <shasum of tarball> |
reports/example.md
Outdated
| - repo: <repo name> | ||
| - link: <link> | ||
| - details: > | ||
| - <number>: |
There was a problem hiding this comment.
do a few example entries.
and the link should include a hash which is only 8 long.
https://github.com/coala/cEPs/commit/e9f75878
not
https://github.com/coala/cEPs/commit/e9f7587856e1c236d37e96f54a0cb4d72069776d
to avoid line length errors
RJ722
force-pushed
the
update_GSoC_report_temp
branch
from
cfb65ac to
1a004fa
Compare
RJ722
force-pushed
the
update_GSoC_report_temp
branch
from
1a004fa to
39bed4b
Compare
Travis tests have failedHey @RJ722, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
li-boxuan
reviewed
Aug 12, 2018
reports/example.md
Outdated
| @@ -8,36 +8,46 @@ organisation: coala | |||
| organisation_link : https://coala.io | |||
There was a problem hiding this comment.
no space before :. YAMLlintbear will complain about that.
reports/example.md
Outdated
| - username: <hackerrank username> | ||
| - link: https://hackerrank.com/<hackerrank username> | ||
| - GitHub: | ||
| - username: <github username> |
There was a problem hiding this comment.
There should be 6 spaces before - username, not 4. Otherwise, YAMLlintbear will complain.
See https://docs.saltstack.com/en/latest/topics/troubleshooting/yaml_idiosyncrasies.html
There was a problem hiding this comment.
Wow, that is super weird. :P
reports/example.md
Outdated
| - link: <link> | ||
| - details: > | ||
| - 1: | ||
| - repo: cEPs |
reports/example.md
Outdated
| - Phase 1 : <phase1 milsetone link> | ||
| - Phase 2 : <phase2 milsetone link> | ||
| - Phase 3 : <phase3 milsetone link> | ||
| - Bonding : <bonding milstone link> |
There was a problem hiding this comment.
milstone was a typo, and you copied that without detecting typo ;)
There was a problem hiding this comment.
Ah, it's beyond me how you guys can actually figure out a typo in the whole english mess. ':D
|
Your commit message doesn't include the issue link |
RJ722
force-pushed
the
update_GSoC_report_temp
branch
from
39bed4b to
d339460
Compare
|
Oops, updating it. Thanks for the review @li-boxuan :-) |
RJ722
force-pushed
the
update_GSoC_report_temp
branch
from
d339460 to
a4f0b1e
Compare
li-boxuan
reviewed
Aug 12, 2018
reports/example.md
Outdated
| - Bonding : <bonding milestone link> | ||
| - Phase 1 : <phase1 milsetone link> | ||
| - Phase 2 : <phase2 milsetone link> | ||
| - Phase 3 : <phase3 milsetone link> |
There was a problem hiding this comment.
milsetone together with above two is also a typo :P
I don't know why, but I have always used the |
RJ722
force-pushed
the
update_GSoC_report_temp
branch
from
a4f0b1e to
9704c4c
Compare
I would suggest sticking to https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html, but it's your choice. |
jayvdb
approved these changes
Aug 12, 2018
|
The colon is wrong, and should not be used, but this is too critical to wait |
|
ack 9704c4c |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward failed! Please fastforward your pull request manually via the command line. Reason: |
jayvdb
force-pushed
the
update_GSoC_report_temp
branch
from
9704c4c to
de8a03e
Compare
|
Also wasnt rebased, so I've fixed the commit message |
Travis tests have failedHey @RJ722, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward failed! Please fastforward your pull request manually via the command line. Reason: |
jayvdb
force-pushed
the
update_GSoC_report_temp
branch
from
de8a03e to
55cc793
Compare
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
|
Hey @RJ722, TravisCI finished with status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes have been made to the GSoC report template:
report_yeartarball_hashCloses: #615