Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating searchbar roundness #763

Closed
wants to merge 4 commits into from
Closed

Updating searchbar roundness #763

wants to merge 4 commits into from

Conversation

dewanshrawat15
Copy link
Member

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@TravisBuddy
Copy link

Travis tests have failed

Hey @dewanshrawat15,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f375b3f0-e3af-11e9-b752-11f331f20c85

@TravisBuddy
Copy link

Hey @dewanshrawat15,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 46211300-e3b1-11e9-b752-11f331f20c85

@TravisBuddy
Copy link

Hey @dewanshrawat15,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f62c5d90-e3b1-11e9-b752-11f331f20c85

@dewanshrawat15
Copy link
Member Author

#760 @KVGarg @jayvdb the search bar has been made more round according to the issue.

Copy link
Contributor

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, this repository isn’t yet configured with CSS check bear so try to run to run csslint on this project and check if there are any issues with ur css addition or not! If there, please correct and amend the changes to your commit.

Also, please squash your commits to one commit! And please improve your commit message.
Checkout git basics http://api.coala.io/en/latest/Developers/Git_Basics.html

@dewanshrawat15
Copy link
Member Author

@KVGarg okay working on it 😄

@TravisBuddy
Copy link

Travis tests have failed

Hey @dewanshrawat15,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7eea63c0-e862-11e9-b0f4-939d566b92ab

Copy link
Contributor

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Squash your commits!

@abhishalya
Copy link
Member

Closing due to inactivity and not so important change.

@abhishalya abhishalya closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants