Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow matching on Num types #1266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow matching on Num types #1266

wants to merge 2 commits into from

Conversation

YarinHeffes
Copy link
Collaborator

Addresses #423

@Izaakwltn
Copy link
Collaborator

I think this could use a few tests, matching on different Num types:

https://github.com/coalton-lang/coalton/blob/main/tests/pattern-matching-tests.lisp

@YarinHeffes
Copy link
Collaborator Author

I think this could use a few tests, matching on different Num types:

https://github.com/coalton-lang/coalton/blob/main/tests/pattern-matching-tests.lisp

I added some tests. This PR does not allow matching on non-literal Num types.

@YarinHeffes YarinHeffes changed the title allow matching on num types Allow matching on Num types Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliaslfox eliaslfox Awaiting requested review from eliaslfox

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YarinHeffes @Izaakwltn