This repository has been archived by the owner on Feb 20, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to indicate intentional savings. currently implemented in two places to see which we like better: on main buckets tab at the bottom of the active buckets list, and on the funders tab by the currently logged in user's name. also adds a confirm dialog for the saving with some explanatory text.
I'd love feedback on the placement and naming of the 'saving' options. @chime-mu and i had discussed possibly putting the 'save' button on the member profile menu (top right corner) but i find this confusing because that menu is not otherwise group-specific. we also discussed keeping it somewhat hidden because we are not what UI will make the most sense in the long term, and letting admins inform their users about the functionality rather than it being self-discovering. i am on the fence about this... i think it keeps our options open which is good, but is more likely to result in a half-built feature which relies on manual intervention.
here's the first option, on the 'funders' tab:
and here's the second, on the buckets tab at the bottom:
when you click the above, a confirm dialog appears to explain:
again, these are mutually exclusive and maybe neither is right yet!
the second change is that i noticed admins can "download CSV" of current users in two separate places, and it does the same thing. one is on the "manage funds" page, and the other is at the top of the funders list. my thought was to replace the latter with an option to download a CSV "report" which would differ in that it would report on user activity rather than simply provide the format to add funds. here's what the button looks like now:
which still only appears if you are an admin.