Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

WIP Feature/saving #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP Feature/saving #353

wants to merge 2 commits into from

Conversation

jessykate
Copy link
Member

add ability to indicate intentional savings. currently implemented in two places to see which we like better: on main buckets tab at the bottom of the active buckets list, and on the funders tab by the currently logged in user's name. also adds a confirm dialog for the saving with some explanatory text.

I'd love feedback on the placement and naming of the 'saving' options. @chime-mu and i had discussed possibly putting the 'save' button on the member profile menu (top right corner) but i find this confusing because that menu is not otherwise group-specific. we also discussed keeping it somewhat hidden because we are not what UI will make the most sense in the long term, and letting admins inform their users about the functionality rather than it being self-discovering. i am on the fence about this... i think it keeps our options open which is good, but is more likely to result in a half-built feature which relies on manual intervention.

here's the first option, on the 'funders' tab:
cb_intentional_save_opt1

and here's the second, on the buckets tab at the bottom:
cb_intentional_save_opt2

when you click the above, a confirm dialog appears to explain:
cb_intentional_save_opt2b

again, these are mutually exclusive and maybe neither is right yet!

the second change is that i noticed admins can "download CSV" of current users in two separate places, and it does the same thing. one is on the "manage funds" page, and the other is at the top of the funders list. my thought was to replace the latter with an option to download a CSV "report" which would differ in that it would report on user activity rather than simply provide the format to add funds. here's what the button looks like now:
cb_intentional_save_admin_report

which still only appears if you are an admin.

… two places to see which we like better. on main buckets tab at the bottom of the active buckets list, and on the funders tab by the currently logged in user's name. also adds a confirm dialog for the saving with some explanatory text.
@jessykate
Copy link
Member Author

PS the saved_funds_at value is not actually being saved to the database for me-- i am seeing a CSRF error when i try to save the field locally, but couldn't debug that on the plane. i'm not sure if it's a real problem or the same issue we've been having with this periodically around (maybe) CNAMEs being out of wack? curious if it works for others :).

@chime-mu
Copy link
Contributor

@jessykate I think (but are not 100% sure) the CSRF issue is a red herring. I've seen the warning pop up all the time, without actually affecting functionality.

I agree with your point about the member profile menu.

Would another option be a button in the same space as the "Invite People" and "Manage Funds" buttons? If not I think I prefer at the bottom of the buckets tab - but mostly because it's well hidden and will make it possible to release without a lot of fuss.

@chime-mu
Copy link
Contributor

And I think the download report is a great idea 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants