test: follow RUF051 recommendations #21518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ruff 0.8.3 enables a new preview rule RUF051 `if-key-in-dict-del`, preferring `.pop()` over a conditional check plus a separate del statement.
jelly
force-pushed
the
new-year-new-ruff
branch
from
78d29dc to
c013109
Compare
allisonkarlitskaya
approved these changes
Jan 14, 2025
| del options['dhcp'] | ||
| options.pop('address', None) | ||
| options.pop('dns', None) | ||
| options.pop('dhcp', None) | ||
| if 'restrict' not in options: | ||
| options['restrict'] = restrict |
There was a problem hiding this comment.
These two adjacent lines look a bit like we might get a future complaint about using .setdefault(), no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff 0.8.3 enables a new preview rule RUF051
if-key-in-dict-del, preferring.pop()over a conditional check plus a separate del statement.