networkmanager: Handle cancelling of superuser changes #21530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening the superuser dialog (necessarily) already initiates the sudo (or similar) process, changes `superuser.allowed` to `null`, and thus triggers all kinds of reinitialization. However, `model` becomes invalid (`model.ready == false`) after cancelling the dialog, so that the page is stuck in the empty state. Fix that by reinitializing the model after superuser changes. Fixes the first part of cockpit-project#19655 (this applies to more pages)
|
See #19655 - this goes much deeper, and this only lightly papers over the root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the superuser dialog (necessarily) already initiates the sudo (or similar) process, changes
superuser.allowedtonull, and thus triggers all kinds of reinitialization. However,modelbecomes invalid (model.ready == false) after cancelling the dialog, so that the page is stuck in the empty state.Fix that by reinitializing the model after superuser changes.
Fixes the first part of #19655 (this applies to more pages)