Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI/e2e infra updates #570

Merged
merged 5 commits into from
Jan 10, 2024
Merged

PSI/e2e infra updates #570

merged 5 commits into from
Jan 10, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jan 9, 2024

This got rolled out already.

This is useful for adding more instances after already deployed ones.
Fedora 39's moreutils-parallel has a completely different CLI now. It
gets the `{}` values as arguments after `--` instead of reading them
from stdin.
shared_net_7 has some intermittent undiagnosed networking trouble, see
Red Hat SNOW ticket 5c1149998723359ca92b4156cebb35a0
@martinpitt martinpitt requested review from jelly and mvollmer January 9, 2024 09:19

ansible-playbook -i inventory/ psi/image-cache.yml
ansible-playbook -f20 -i inventory/ psi/image-cache.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit, --forks would be what I prefer reading here. 20 sounds like a lot then again never seen ansible-playbook runs "eat resources" with the default 5.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the client side it's really just a bunch of ssh processes. I find 20 to be just fine for all our cockpituous cases, we don't do anything expensive on the caller side.

But I'll change to --forks indeed.

jelly
jelly previously approved these changes Jan 9, 2024
I did this manually in the previous install, and forgot to automate it.
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's going on here. :-)

@martinpitt
Copy link
Member Author

@mvollmer commits 1, 2, 4 should be obvious; 3 is the broken networking that I reported to the admins, and so far changing the network to shared_net_2 has worked. It's more or less just "try them and see what works". I'm happy to talk you through commit 5 "Configure local image S3 store in e2e" if you are interested.

Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@martinpitt martinpitt merged commit 925d1e6 into main Jan 10, 2024
3 checks passed
@martinpitt martinpitt deleted the psi branch January 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants