-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tools to be able improve ISO for rhel4edge #571
Conversation
jscotka
commented
Jan 22, 2024
•
edited by martinpitt
Loading
edited by martinpitt
- Discuss the approach in add customization script for fleet.ks in rhel4edge iso file bots#5810 first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some questions though. Deploying a new tasks container is a two-day effort, so I'd like to sort this out first.
nc \ | ||
net-tools \ | ||
nodejs-devel \ | ||
npm \ | ||
ostree \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you need this for? I'm rather sceptical that this will work in an unprivileged container. You can run toolbox create --image quay.io/cockpit/tasks -c cockpit
to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is based on dependencies inside podman image what was used before: https://github.com/loadtheaccumulator/fleet-iso-util/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But https://github.com/loadtheaccumulator/fleet-iso-util/blob/main/fleetkick.sh doesn't use ostree anywhere?
virt-install && \ | ||
virt-install \ | ||
xorriso && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The &&
needs to move a line up.
@@ -48,10 +53,12 @@ RUN dnf -y update && \ | |||
rpmdevtools \ | |||
rsync \ | |||
socat \ | |||
syslinux \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is certainly a curious thing to have in the tasks container -- certainly the rhel4edge builds from image builder already have a boot loader? We want to test these images, not apply a dozen hacks to fix their boot. What's that for?
as original PR in bots is closed, closing also this one as not necessary. |