tasks: Install types-PyYAML into container #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Not necessary any more. |
|
I'm not against this. I was just against skipping mypy if this was missing. All the better if we have it! |
|
@allisonkarlitskaya Heh, I understood. In the end this is tiny, so let's do that. More fodder for our container-update bots 😁 |
allisonkarlitskaya
approved these changes
Mar 21, 2024
| @@ -67,7 +67,7 @@ RUN dnf -y update && \ | |||
| dnf -y builddep --setopt=install_weak_deps=False /tmp/cockpit.spec && \ | |||
| rm /tmp/cockpit.spec && \ | |||
| dnf clean all && \ | |||
| pip install ruff | |||
| pip install ruff types-PyYAML | |||
There was a problem hiding this comment.
Okay, but one more and we start using the \s :)
This is a prerequisite for proper mypy testing of the upcoming pytest in PR #606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for proper mypy testing of the upcoming pytest in PR #606