tasks: Fix image cache in local podman container, fix ruff 0.7 errors #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These days we have to explicitly set `$COCKPIT_IMAGES_DATA_DIR`. Drop the explicit "bash" command, it's not necessary any more.
|
Wohoo, we haven't run cockpituous CI tasks in a while -- new ruff fun. Fixed (ruff could do it automatically) |
martinpitt
changed the title
martinpitt
changed the title
|
Meh -- this now says exactly the opposite. I cannot reproduce this, the tasks container's ruff-0.6.7-1.fc40.x86_64 says "all passed". Let's disable that rule. |
Different ruff versions have contradicting opinions about how to write the pytest decorators. Writing them with () as we do now is more general, so let's keep it that way.
martinpitt
force-pushed
the
tasks-readme
branch
from
788c073 to
8179fe8
Compare
jelly
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These days we have to explicitly set
$COCKPIT_IMAGES_DATA_DIR.Drop the explicit "bash" command, it's not necessary any more.