tasks: Delay webhook startup; metrics: Adjust config to Prometheus 3 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting the AMQP and webhook container in parallel very often runs into webhook not yet being able to connect to the AMPQ server, and thus getting trapped in a crash loop until it wins the race. Delay the webhook startup by 10 seconds. This isn't scientific, but good enough for the two times a year that we restart this pod.
The "alertmanagers:" schema changed.
jelly
approved these changes
Dec 16, 2024
Yes, absolutely -- this was a quick hack to unbreak the setup. I'll look into updating the webhook script itself. It already has a retry loop, which apparently doesn't work. Dang, I should have captured the precise backtrace.. |
|
See commit 06c2717. I put it on my TODO list to fix this properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fallout from my CI wrestling today (for OpenSSL 3 certs, this was unrelated Yak shaving).