webhook: Retry OSError on queue connection failure #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import ordering, docstrings, and canonical logging statements.
Commit 06c2717 introduced a retry loop for connecting to AMQP, as these two containers start at the same time in the OpenShift deployment. However, these days the webhook often fails with `ssl.SSLEOFError` (with parents `SSLError` and `OSError`), which doesn't fit `AMQPError`. So intercept this as well. With that we can revert the static sleep from commit 169b53b again. Fixes #635
|
Rebuilt, tested locally, deployed, works ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 06c2717 introduced a retry loop for connecting to AMQP, as
these two containers start at the same time in the OpenShift deployment.
However, these days the webhook often fails with
ssl.SSLEOFError(with parents
SSLErrorandOSError), which doesn't fitAMQPError.So intercept this as well.
With that we can revert the static sleep from commit 169b53b
again.
Fixes #635