package.json: bump eslint to ^8.0.0 and all eslint-x dependencies #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So at to keep starter-kit as template project, let's fix here possible issues and then apply to external projects as rhinstaller/anaconda#4035 (comment) |
|
Fails to build in CentOS 8 stream: ... too old node.js? Let's fix that by not running eslint during RPM build -- it doesn't do anything good there, just waste time. |
It's useless there -- any style error that may happen there has already slipped through the upstream release, and at RPM build time there is nothing that can be done about it. It just wastes time. This allows us to bump eslint to a newer version which is incompatible with the older node.js on RHEL/CentOS 8.
So as to satisfy the new eslint peer dependency. In addition drop eslint-config-standard-react as it does not release anymore, and eslint 8.x is not compatible with the available last release. standard/eslint-config-standard-react#69 Replace it with https://github.com/facebook/create-react-app#readme which is actively maintained. Lastly drop the deprecated https://github.com/standard/eslint-plugin-standard
martinpitt
force-pushed
the
drop-depr-eslint-config-standard-react
branch
from
c44587c
to
3d490c6
Compare
martinpitt
reviewed
Apr 11, 2022
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as to satisfy the new eslint peer dependency.
In addition drop eslint-config-standard-react as it does not release
anymore, and eslint 8.x is not compatible with the available last
release.
standard/eslint-config-standard-react#69
Replace it with https://github.com/facebook/create-react-app#readme
which is actively maintained.
Lastly drop the deprecated
https://github.com/standard/eslint-plugin-standard