correct stackprof

cockroachdb · Jan 22, 2025 · 7f069f2 · 7f069f2
1 parent fe3c598
commit 7f069f2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -88,7 +88,7 @@ jobs:
           done
           cat ${{ github.workspace }}/setup.sql | cockroach sql --insecure
       - name: Test
-        run: AR_LOG=summary bundle exec rake test TESTOPTS='--profile=5 --verbose'
+        run: AR_LOG=summary bundle exec rake test TESTOPTS='--stackprof=tmp/stackprof.dump --profile-setup --profile=5 --verbose'
       - name: Upload test information
         uses: actions/upload-artifact@v4
         if: always()

diff --git a/Gemfile b/Gemfile
@@ -58,7 +58,7 @@ group :development, :test do
   gem "minitest-github_action_reporter", github: "BuonOmo/minitest-github_action_reporter", require: "minitest/github_action_reporter_plugin"
   gem "ostruct", "~> 0.6"
 
-  gem "stackprof"
+  gem "minitest-stackprof"
 
   # Gems used for tests meta-programming.
   gem "parser"

diff --git a/test/cases/helper_cockroachdb.rb b/test/cases/helper_cockroachdb.rb
@@ -223,7 +223,8 @@ class BaseCompatibilityTest < ActiveRecord::TestCase
   self.use_transactional_tests = false
 end
 
-require "stackprof"
 FileUtils.mkdir_p("tmp")
-StackProf.start(mode: :wall, interval: 1000, out: "tmp/stackprof.dump", raw: true)
-Minitest.after_run { StackProf.stop; StackProf.results("tmp/stackprof.dump") }
+
+# require "stackprof"
+# StackProf.start(mode: :wall, interval: 1000, out: "tmp/stackprof.dump", raw: true)
+# Minitest.after_run { StackProf.stop; StackProf.results("tmp/stackprof.dump") }