chore: Backport #345 to 7-0-stable #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BuonOmo Do you by any chance have updates on the status of the backport? |
|
@shaunma sorry for the latency here. I'm making the tests pass so that we could go on with the PR. You can always pinpoint the gem "activerecord-cockroachdb-adapter", github: "cockroachdb/activerecord-cockroachdb-adapter", branch: "7-0-stable" |
BuonOmo
force-pushed
the
7-0-stable
branch
8 times, most recently
from
a350e5e to
112b7eb
Compare
This fixes the `IOError` we could encounter in tests.
Found using:
```ruby
def bugmsg(header, stdout)
bugged = begin; print; rescue IOError; "💥 "; end
STDOUT.puts "🤞#{header.rjust(17)}: stdout=#{stdout.inspect} " \
"#{bugged}(at #{caller_locations(2, 1).first})"
end
trace_var :$stdout, (proc { bugmsg("$stdout=", _1) })
TracePoint.trace(:a_return) do |tp|
next unless tp.method_id == :reopen && tp.self == $stdout
bugmsg("$stdout#reopen", $stdout)
end
```
This fixes the test `#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas`.
- Allow using various schemas for the console, and always start with a clean slate. - If no internet, select latest used Rails version. - Allow to easily show schema loading logs. - Closer CRDB configuration between CI and local dev. - Add editor config file.
Previously the action would be executed twice, once by a push event and once by a pull_request event.
This wrapper job will have a stable name, so it's easy to configure a required check on it.
Avoid 87% of the `#disable_referential_integrity` calls made in fixture setup by just trying first without disabling and just disabling in case of failure. Also batch foreign keys removals and addition (for clarity only).
|
NOTE: I backported a lot of test related commits to be sure we have tests passing (or close to be passing, as they weren't always passing at that time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is not there to be merged, but to run tests and have the usual review process before publish a 7.0 compatible backport for this commit.