Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/teamcity: add changes to enable openmetrics in nightly roachtests #135564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build/teamcity: add changes to enable openmetrics in nightly roachtests #135564

wants to merge 1 commit into from
+63 −42

Conversation

sambhav-jain-16
Copy link
Contributor

@sambhav-jain-16 sambhav-jain-16 commented Nov 18, 2024 •
edited
Loading

There was a regression in #135239.
The change was reverted and this PR aims to fix the regressions

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@sambhav-jain-16 sambhav-jain-16 changed the title Crdb 41992 build/teamcity: add changes to enable openmetrics in nightly roachtests Nov 18, 2024
@sambhav-jain-16
Copy link
Contributor Author

Test runs:

json: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Roachtest_Openmetrics_Gce/17906085?buildTab=log&focusLine=2934&logView=flowAware&linesState=571

openmetrics: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Roachtest_Openmetrics_Gce/17906084?buildTab=overview&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true

@sambhav-jain-16
build/teamcity: add changes to enable openmetrics in nightly roachtests
596260c 
There was a regression in cockroachdb#135239.
The change was reverted and this PR aims to fix the regressions

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852

Release note: None
@sambhav-jain-16 sambhav-jain-16 marked this pull request as ready for review November 25, 2024 11:35
@sambhav-jain-16 sambhav-jain-16 requested a review from a team as a code owner November 25, 2024 11:35
@sambhav-jain-16 sambhav-jain-16 requested review from srosenberg and nameisbhaskar and removed request for a team November 25, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg Awaiting requested review from srosenberg

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sambhav-jain-16 @cockroach-teamcity