sql/sem/tree: fix tuple pretty print when tuple has 1 element #135938
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
|
|
This change is |
tigrato
changed the title
tigrato
changed the title
When using `sql/sem/tree.Tuple` to generate SQL statements for IN
operators, the produced output is incorrect if the tupple only has one
element. The output includes an extra `,`.
As an example, the following
```go
&tree.Tuple{
Exprs: []tree.Expr{
tree.NewStrVal("val1"),
},
}
```
Is incorrectly mapped to `('val1',)` instead of `('val1')`.
Because of the extra `,`, sql parsers fail to parse the input.
This commit aims to fix these conditions and remove the trailing `,`.
Fixes cockroachdb#135939
release note (bug fix): Fixed a bug that caused `pkg/sql/sem/tree.Tuple`
to generate invalid SQL statements when the tuple only has one element.
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
sql/sem/tree.Tupleto generate SQL statements for IN operators, the produced output is incorrect if the tuple only has one element. The output includes an extra,.As an example, the following
Is incorrectly mapped to
('val1',)instead of('val1').Because of the extra
,, sql parsers fail to parse the input.This commit aims to fix these conditions and remove the trailing
,.