ui: fix bug where index details page link is broken in cc console #135941
+34
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kyle-a-wong
force-pushed
the
fix_index_details_cccloud
branch
from
3f53bae
to
bbbaf44
Compare
Fixes the url used in cc console when clicking on an index from the table details index tab. This bug only affects clusters in version 24.3. Also changes the index details page breadcrumbs to always render the same breadcrumb, always linking to the new databases pages. There is no longer a need define seperate logic for CC console and db console because both have converged to the same path definitions for the databases, database details, and table details pages. Lastly, this commit fixes a small bug that exists in the legacy BreadCrumb component that can cause bread crumb links to disappear due to the modification of the component prop using, using .pop() on the items array. Part of: cockroachdb#135857 Epic: none Release note: none
kyle-a-wong
force-pushed
the
fix_index_details_cccloud
branch
from
bbbaf44
to
2e787c0
Compare
dhartunian
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the url used in cc console when clicking on an index from the table details index tab. This bug only affects clusters in version 24.3.
Also changes the index details page breadcrumbs to always render the same breadcrumb, always linking to the new databases pages. There is no longer a need define seperate logic for CC console and db console because both have converged to the same path definitions for the databases, database details, and table details pages.
Lastly, this commit fixes a small bug that exists in the legacy BreadCrumb component that can cause bread crumb links to disappear due to the modification of the component prop using, using .pop() on the items array.
Part of: #135857
Epic: none
Release note: none