kvserver: add setting to reject overly large transactions #135945
+52
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had an ability to reject transactions that had too many intents, however this was tied together with the limit where we condense spans. The limits have too different purposes and should be set independently. The condense size limit (kv.transaction.max_intents_bytes) is used to protect the memory on the client side by using less precise tracking once it passes a certain size. The new limit (kv.transaction.reject_intents_bytes) is intended to protect the server side by preventing a client from creating a transaction with too many bytes in it. Large transactions are suboptimal for a few reasons. Epic: none Release note (ops change): Adds a new configurable parameter kv.transaction.reject_intents_bytes which will prevent client transactions from getting too large.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had an ability to reject transactions that had too many intents, however this was tied together with the limit where we condense spans. The limits have too different purposes and should be set independently. The condense size limit
(kv.transaction.max_intents_bytes) is used to protect the memory on the client side by using less precise tracking once it passes a certain size. The new limit (kv.transaction.reject_intents_bytes) is intended to protect the server side by preventing a client from creating a transaction with too many bytes in it. Large transactions are suboptimal for a few reasons.
Epic: none
Release note (ops change): Adds a new configurable parameter kv.transaction.reject_intents_bytes which will prevent client transactions from getting too large.