Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2: roachtest: fix rebalance/by-load/*/mixed-version shared process tests #135947

Open
wants to merge 2 commits into
base: release-24.2
Choose a base branch
from
Open

release-24.2: roachtest: fix rebalance/by-load/*/mixed-version shared process tests #135947

wants to merge 2 commits into from
+18 −0

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 21, 2024 •
edited by kvoli
Loading

Backport 2/2 commits from #131787 on behalf of @kvoli.

/cc @cockroachdb/release

In #129117, rebalance/by-load/*/mixed-version roachtest had
shared-process multi-tenancy introduced, which would occasionally cause
these tests to fail erroneously.

The cause of all the failures was identical, CPU utilization of some
nodes which couldn't have been possible, > 100%, e.g.,

CPU not evenly balanced after timeout: outside bounds mean=102.5 tolerance=20.0% (±20.5) bounds=[82.0, 123.0]
below  = [s3: 81 (-20.7%), s5: 65 (-36.5%)]
within = [s2: 116 (+14.0%), s4: 92 (-9.7%), s6: 88 (-13.2%)]
above  = [s1: 170 (+66.1%)]

As the query would aggregate every tenant's timeseries data on a given
node, instead of only the system tenant.

Update the timeseries utility used to query the CPU to also take in a
TenantID parameter, which is then used to query only the system
tenant.

Fixes: #129962
Fixes: #131274
Fixes: #129464
Release note: None

Release justification: Test only.

@kvoli
roachtest: fail rebalance/by-load/* if cpu ∉ [0,100]
29e3dec 
`rebalance/by-load/*` roachtests query the internal timeseries database
via http, specifically for the
`cr.node.sys.cpu.combined.percent-normalized` metric, which represents
the core-count normalized CPU utilization of each node within the
cluster over the query window.

The value should inherently be bounded in [0,100], as it would be
impossible to use more than all the cores on a host, or use less than
none of them.

Assert as much.

Informs: #129962
Informs: #131274
Informs: #129464

Release note: None
@kvoli
roachtest: use system tenant when querying ts in rebalance/by-load
e506c64 
In #129117, `rebalance/by-load/*/mixed-version` roachtest had
shared-process multi-tenancy introduced, which would occasionally cause
these tests to fail erroneously.

The cause of all the failures was identical, CPU utilization of some
nodes which couldn't have been possible, > 100%, e.g.,

```
CPU not evenly balanced after timeout: outside bounds mean=102.5 tolerance=20.0% (±20.5) bounds=[82.0, 123.0]
below  = [s3: 81 (-20.7%), s5: 65 (-36.5%)]
within = [s2: 116 (+14.0%), s4: 92 (-9.7%), s6: 88 (-13.2%)]
above  = [s1: 170 (+66.1%)]
```

As the query would aggregate every tenant's timeseries data on a given
node, instead of only the system tenant.

Update the timeseries utility used to query the CPU to also take in a
`TenantID` parameter, which is then used to query only the system
tenant.

Fixes: #129962
Fixes: #131274
Fixes: #129464
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 21, 2024 21:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-131787 branch from 66a15b1 to e506c64 Compare November 21, 2024 21:48
@blathers-crl blathers-crl bot requested review from herkolategan and removed request for a team November 21, 2024 21:48
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 21, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 21, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 21, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli mentioned this pull request Nov 21, 2024
Merged
@tbg tbg removed their request for review November 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arulajmani arulajmani arulajmani approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong is a code owner automatically assigned from cockroachdb/test-eng

@iskettaneh iskettaneh Awaiting requested review from iskettaneh

@kvoli kvoli Awaiting requested review from kvoli

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@kvoli kvoli

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @arulajmani @kvoli