sql: refactor flaky logic test as a unit test #135957
Open
+38
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pulls out a subset of `zone_config_system_tenant` logic test file into a separate unit test. This is done because this test is known to cause undesired diff to be included when using `--rewrite` option over the logic test suite (see 0266dcd). This commit fixes the undesired diff that was checked in recently in cd1fac3. Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls out a subset of
zone_config_system_tenantlogic test file into a separate unit test. This is done because this test is known to cause undesired diff to be included when using--rewriteoption over the logic test suite (see 0266dcd). This commit fixes the undesired diff that was checked in recently in cd1fac3.Fixes: #135896.
Fixes: #135897.
Release note: None