release-24.1: sql: catch panics in virtual table generators #135965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #135761 on behalf of @yuzefovich.
/cc @cockroachdb/release
This commit improves the stability of CRDB by introducing the panic-catcher into the goroutine that is spun up for generating the contents of the virtual tables. Previously, if the generator function ran into a panic, this would crash the server, and now instead only the query requiring the contents of the vtable will see an error.
Fixes: #135760.
Release note: None
Release justification: low-risk stability improvement.