roachtest/tlp: randomly force generic query plans #145256
Open
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic query plans are now forced for 25% of TLP queries. Note that only one type of TLP query uses placeholders, which are required for "interesting" generic query plans, simple `SELECT .. WHERE ..` queries. Joins and grouping do not yet use placeholders. Fixes cockroachdb#128912 Release note: None
|
This change is |
michae2
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Thanks for doing this!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mw5h)
pkg/cmd/roachtest/tests/tlp.go line 226 at r1 (raw file):
const ( forceGeneric = "SET plan_cache_mode = force_generic_plan" auto = "SET plan_cache_mode = auto"
nit: It might be clearer to use RESET plan_cache_mode if the purpose is to assign it back to the default.
pkg/cmd/roachtest/tests/tlp.go line 232 at r1 (raw file):
return err } logStmt(forceGeneric)
nit: I think we only want to do this if a TLP mismatch is found, otherwise the log will be full of these statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic query plans are now forced for 25% of TLP queries. Note that
only one type of TLP query uses placeholders, which are required for
"interesting" generic query plans, simple
SELECT .. WHERE ..queries.Joins and grouping do not yet use placeholders.
Fixes #128912
Release note: None