-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-11984 PR #135924 - sql: label latency histograms with statement fingerprint #19322
Conversation
Updated child-metrics-table.md and metric-names.md to use page.version.version. Updated cockroachcloud metrics-tab.md and metrics-essential.md to use site.current_cloud_version.
…mat=csv > metrics-list.csv against v25.1.0-beta.1, v24.3.3, v24.2.8. Manually lower-cased column headers.
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
Renamed child-metrics.yml to multi-dimensional-metrics.yml.
…il and sql.query.unique.count. In multi-dimensional-metrics.yml, added sql.exec.latency.detail with detailed-latency feature and replaced child_metrics_id with multi_dimensional_metric_id. Renamed child-metrics-table.md include file to multi-dimensional-metrics-table.md and updated to use multi_dimensional_metric_id. In multi-dimensional-metrics.md, updated includes to use multi-dimensional-metrics-table.md. In sidebar-data/reference.json, set-up-logical-data-replication.md, and logical-data-replication-monitoring, updated link from child-metrics.md to multi-dimensional-metrics.md.
In multi-dimensional-metrics.md, added section Enable detailed latency metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice warning on the details latency metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes DOC-11984
Renamed Child Metrics page to Multi-dimensional Metrics page. Added section Enable detailed latency metrics to Multi-dimensional Metrics page.
Rendered previews: