Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (Enterprise) from nav title for SQL statements from v23.1 onward #19332

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Remove (Enterprise) from nav title for SQL statements from v23.1 onward #19332

merged 1 commit into from
Jan 30, 2025

Conversation

kathancox
Copy link
Contributor

Fixes DOC-12191

@github-actions GitHub Actions
Copy link

Files changed:

  • src/current/_includes/v23.1/sidebar-data/sql.json
  • src/current/_includes/v23.2/sidebar-data/sql.json
  • src/current/_includes/v24.1/sidebar-data/sql.json
  • src/current/_includes/v24.2/sidebar-data/sql.json
  • src/current/_includes/v24.3/sidebar-data/sql.json
  • src/current/_includes/v25.1/sidebar-data/sql.json

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 3f2d52c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/679bb5c4a82f4f0008759d2e

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 3f2d52c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/679bb5c42668dd00088948be

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 3f2d52c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/679bb5c42668dd00088948ba
😎 Deploy Preview https://deploy-preview-19332--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox requested a review from rmloveland January 30, 2025 16:39
rmloveland
rmloveland approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! THANK YOU!!!!

@kathancox kathancox force-pushed the remove-enterprise-from-nav-sql-ref branch from 6cc25ed to 3f2d52c Compare January 30, 2025 17:24
@kathancox kathancox merged commit 8606c66 into main Jan 30, 2025
6 checks passed
@kathancox kathancox deleted the remove-enterprise-from-nav-sql-ref branch January 30, 2025 17:37
@kathancox
Copy link
Contributor Author

TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmloveland rmloveland rmloveland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathancox @rmloveland