Introduce InsnBuffer and other improvements #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
p4zuu
commented
Jan 11, 2024
p4zuu
commented
- Introduce InsnBuffer for similar Instructions fields.
- Add unit tests for x86 instructions deocding
- Add documentation for svsm::cpu::insn
p4zuu
force-pushed
the
insn_buffer
branch
2 times, most recently
from
43ada50 to
e2be477
Compare
00xc
reviewed
Jan 24, 2024
|
Hi Thomas, In general this looks good to me. What is you long-term plan with the decoder, do you plan to turn it into a full x86-64 instruction decoder at some point? |
The Instruction type uses u8 arrays of different sizes, let's declare a new generic InsnBuffer making the Instruction fields handling prettier. Also declare a Index and IndexMut traits for InsnBuffer to make indexing easier. Signed-off-by: Thomas Leroy <[email protected]>
Since not all x86 instructions have prefixes, let's use Instruction::prefixes as an Option, to which we assigne a Some() only if a prefix is found while decoding. Signed-off-by: Thomas Leroy <[email protected]>
Add a few lines of documentation for insn mod. Signed-off-by: Thomas Leroy <[email protected]>
We had in mind with Carlos that we could give this project to an intern or a working student. |
|
Alright, at some point we need a full decoder, but there is still some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.