Get rid of some mutable global statics #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this code a method of struct X86Tss and remove it from the open coded function. Signed-off-by: Joerg Roedel <[email protected]>
Fix the unsafe mutable accesses to the static GDT by wrapping it into a structure and add methods for manipulation. The structure is now protected by a lock which serializes mutable accesses. Signed-off-by: Joerg Roedel <[email protected]>
Replace the GLOBAL_IDT static variable with a non-public global struct which can only be accessed via safe locking. This removes all mutable accesses to a global static for the IDT case. Signed-off-by: Joerg Roedel <[email protected]>
Remove handling around SECRETS_PAGE and replace it with a decent struct and locking. That gets rid the accesses to the global mutable SECRETE_PAGE variable. Signed-off-by: Joerg Roedel <[email protected]>
With recent nightly compilers this warning appears:
warning: field `0` is never read
--> src/mm/alloc.rs:1321:28
|
1321 | pub struct TestRootMem<'a>(LockGuard<'a, ()>);
| ----------- ^^^^^^^^^^^^^^^^^
| |
| field in this struct
|
Silence this warning.
Signed-off-by: Joerg Roedel <[email protected]>
joergroedel
force-pushed
the
mutable-static
branch
from
05f3c48 to
5ffc83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add decent implementations for the GDT, IDT and SecretsPage which require proper locking to make modifications.
This fixes a couple of warnings triggered by the latest Rust nightly compiler.