-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize code size for text-utils.ts #18262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Package size ⤵ -1062 bytes, old: 5225108, new: 5224046Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -3959,16 +3959,16 @@
export function fragmentText(stringToken: string, allWidth: number, maxWidth: number, measureText: (string: string) => number): string[];
export const BASELINE_RATIO = 0.26;
export const MIDDLE_RATIO: number;
export class LRUCache {
- constructor(size: any);
- moveToHead(node: any): void;
- put(key: any, value: any): void;
- remove(node: any): void;
- get(key: any): number | null;
+ constructor(size: number);
+ moveToHead(node: __private._cocos_2d_utils_text_utils__ICacheNode): void;
+ put(key: string, value: number): void;
+ remove(node: __private._cocos_2d_utils_text_utils__ICacheNode): void;
+ get(key: string): number | null;
clear(): void;
- has(key: any): boolean;
- delete(key: any): void;
+ has(key: string): boolean;
+ delete(key: string): void;
}
/**
* @en The dynamic atlas manager which manages all runtime dynamic packed atlas texture for UI rendering.
* It generates a maximum of [[maxAtlasCount]] atlas texture, all atlas texture have the size of [[textureSize]].
@@ -61932,8 +61932,14 @@
* @param {Number} y
*/
drawTextureAt(image: ImageAsset, x: number, y: number): void;
}
+ export interface _cocos_2d_utils_text_utils__ICacheNode {
+ key: string;
+ value: number;
+ prev: _cocos_2d_utils_text_utils__ICacheNode | null;
+ next: _cocos_2d_utils_text_utils__ICacheNode | null;
+ }
/**
* @en The instance of [[MorphRendering]] for dedicated control in the mesh renderer.
* The root [[MorphRendering]] is owned by [[Mesh]] asset, each [[MeshRenderer]] can have its own morph rendering instance.
* @zh 用于网格渲染器中独立控制 [[MorphRendering]] 的实例。原始 [[MorphRendering]] 被 [[Mesh]] 资源持有,每个 [[MeshRenderer]] 都持有自己的形变网格渲染实例。
|
minggo
reviewed
Feb 5, 2025
private declare head; | ||
private declare tail; | ||
private head: ICacheNode | null = null; | ||
private tail: ICacheNode | null = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use declare?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because head
and tail
are not assigned in constructor
, so we need to initialize them to null
while definition.
minggo
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #18222
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: