Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): enhance component accessor type safety with generics #18282

Open
wants to merge 1 commit into
base: v3.8.6
Choose a base branch
from
Open

refactor(components): enhance component accessor type safety with generics #18282

wants to merge 1 commit into from

Conversation

9romise
Copy link
Contributor

@9romise 9romise commented Feb 6, 2025

Re: #

Changelog

  • Convert component accessor methods to use generic types for precise type inference
  • Improve developer experience with auto-completion and type checking

Before:

const clz = node.getComponent('clz') as CLZ | null

After:

const clz = node.getComponent<CLZ>('clz')

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
Copy link
Contributor

@cocos-robot run test cases

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

@9romise, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL reflection-probe
mac PASS PASS FAIL reflection-probe

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

@9romise, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9romise @dumganhar