Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in protocol #155

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocols/platform/ios/AdsWrapper.mm
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ + (NSString*)buildVersion

// adapted from http://stackoverflow.com/questions/25540140/can-one-determine-the-ios-sdk-version-used-to-build-a-binary-programmatically
// form character set of digits and punctuation
NSMutableCharacterSet *characterSet = [[NSCharacterSet decimalDigitCharacterSet] mutableCopy];
NSMutableCharacterSet *characterSet = [[[NSCharacterSet decimalDigitCharacterSet] mutableCopy] autorelease];

[characterSet formUnionWithCharacterSet: [NSCharacterSet punctuationCharacterSet]];

Expand Down
2 changes: 1 addition & 1 deletion protocols/platform/ios/ParseUtils.m
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ + (NSString *) NSDictionaryToNSString:(id)dic{
if (! jsonData) {
NSLog(@"Got an error: %@", error);
} else {
result = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
result = [[[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding] autorelease];
}
return result;
}
Expand Down
1 change: 1 addition & 0 deletions protocols/platform/ios/PluginFactory.mm
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ of this software and associated documentation files (the "Software"), to deal
pRet->setPluginName(name);
PluginUtilsIOS::initOCPlugin(pRet, obj, name);
}
[obj release];
} while(0);

return pRet;
Expand Down
2 changes: 1 addition & 1 deletion protocols/platform/ios/PluginUtilsIOS.mm
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ of this software and associated documentation files (the "Software"), to deal
void PluginUtilsIOS::initOCPlugin(PluginProtocol* pPlugin, id ocObj, const char* className)
{
PluginOCData* pData = new PluginOCData();
pData->obj = ocObj;
pData->obj = [ocObj retain];
pData->className = className;
PluginUtilsIOS::setPluginOCData(pPlugin, pData);
}
Expand Down